Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix animation glitch on iOS 17 #12

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix animation glitch on iOS 17 #12

wants to merge 5 commits into from

Conversation

borsosbe
Copy link

  • Remove combine
  • For iOS 17 or later use the new animation callback
  • Below that use Task with a delay based on Liquid period
  • Tested on physical devices running iOS 16, 17

@borsosbe borsosbe mentioned this pull request Aug 18, 2024
Open
@mplawley
Copy link

I encountered the same animation glitch with the repo's README's example Liquid code and pointed my Liquid package dependency to commit dbd0a02b00de9a4d0171cf63b4998991d13b8502.

I tested the fix on this PR on the following devices:

  • iPhone 15 simulator running iOS 16.1.
  • iPhone 15 simulator running iOS 17.2.
  • iPhone 16 Pro (real device) running iOS 18.0.1

It worked for all three.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bohdansasko bohdansasko bohdansasko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@borsosbe @mplawley @bohdansasko